Issue 4696004: openssl build fixes, and tidy the build files

Issue 4696004: openssl build fixes, and tidy the build files (Closed)

Created:
10 years, 1 month ago by joth

Modified:
9 years, 7 months ago

Reviewers:
bulach, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

openssl build fixes, and tidy the build files Split out of http://codereview.chromium.org/4691003/ BUG=None TEST=builds... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65801

Patch Set 2 : leave build files alone except for the minimal fixes #

Total comments: 3

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
M	build/linux/system.gyp	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/common/net/url_fetcher_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/net_test_suite.h	View		2 chunks	+3 lines, -1 line	3 comments	Download
M	net/net.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

joth

@rsleevi, thanks for the suggestion to split this out and tidy it, looks better now.

10 years, 1 month ago (2010-11-11 11:16:52 UTC) #1

bulach

LGTM thanks joth! one nit below, and as we chatted, let's do the complete tidy ...

10 years, 1 month ago (2010-11-11 14:08:30 UTC) #2

wtc

LGTM. http://codereview.chromium.org/4696004/diff/3001/net/base/net_test_suite.h File net/base/net_test_suite.h (right): http://codereview.chromium.org/4696004/diff/3001/net/base/net_test_suite.h#newcode48 net/base/net_test_suite.h:48: #endif // defined(OS_LINUX) You can also just delete ...

10 years, 1 month ago (2010-11-11 14:30:08 UTC) #3

joth

10 years, 1 month ago (2010-11-11 16:52:02 UTC) #4

Thanks, landed.

http://codereview.chromium.org/4696004/diff/3001/net/base/net_test_suite.h
File net/base/net_test_suite.h (right):

http://codereview.chromium.org/4696004/diff/3001/net/base/net_test_suite.h#ne...
net/base/net_test_suite.h:48: #endif  // defined(OS_LINUX)
On 2010/11/11 14:30:09, wtc wrote:
> You can also just delete this comment.

Done.

Expand Messages | Collapse Messages