Removing redundant stubs for API functions.

src/x64/macro-assembler-x64.h

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 795 matching lines @@
   void CallExternalReference(const ExternalReference& ext,
                              int num_arguments);
 
   // Tail call of a runtime routine (jump).
   // Like JumpToExternalReference, but also takes care of passing the number
   // of parameters.
   void TailCallExternalReference(const ExternalReference& ext,
                                  int num_arguments,
                                  int result_size);
 
+  MUST_USE_RESULT MaybeObject* TryTailCallExternalReference(
+      const ExternalReference& ext, int num_arguments, int result_size);
+
   // Convenience function: tail call a runtime routine (jump).
   void TailCallRuntime(Runtime::FunctionId fid,
                        int num_arguments,
                        int result_size);
 
+  MUST_USE_RESULT  MaybeObject* TryTailCallRuntime(Runtime::FunctionId fid,
+                                                   int num_arguments,
+                                                   int result_size);
+
   // Jump to a runtime routine.
   void JumpToExternalReference(const ExternalReference& ext, int result_size);
 
+  // Jump to a runtime routine.
+  MaybeObject* TryJumpToExternalReference(const ExternalReference& ext,
+                                          int result_size);
+
   // Prepares stack to put arguments (aligns and so on).
-  // Uses calle-saved esi to restore stack state after call.
-  void PrepareCallApiFunction(int stack_space);
+  // Uses calle-saved esi to restore stack state after call. In WIN64 puts

[antonm, 2010/11/13 11:34:46]

esi -> rsi
calle -> callee

[antonm, 2010/11/13 11:34:46]

"In WIN64 puts" doesn't sound fine imho.

WIN64 calling conventions require or something of that kind

[SeRya, 2010/11/15 12:09:11]

Done.

+  // the pointer to the return value slot into rcx (rcx must be preserverd
+  // untill TryCallApiFunctionAndReturn).

[antonm, 2010/11/13 11:34:46]

untill -> until

[SeRya, 2010/11/15 12:09:11]

Done.

+  void PrepareCallApiFunction(int stack_space, int argc);

[antonm, 2010/11/13 11:34:46]

Please, add comments about semantics of stack_space and argc

[SeRya, 2010/11/15 12:09:11]

Done.

 
   // Tail call an API function (jump). Allocates HandleScope, extracts
   // returned value from handle and propogates exceptions.
   // Clobbers ebx, edi and caller-save registers.
-  void CallApiFunctionAndReturn(ApiFunction* function);
+  MUST_USE_RESULT MaybeObject* TryCallApiFunctionAndReturn(

[antonm, 2010/11/13 11:34:46]

I think you should unify doc with ia32 variant

[SeRya, 2010/11/15 12:09:11]

Done.

+      ApiFunction* function);
 
   // Before calling a C-function from generated code, align arguments on stack.
   // After aligning the frame, arguments must be stored in esp[0], esp[4],
   // etc., not pushed. The argument count assumes all arguments are word sized.
   // The number of slots reserved for arguments depends on platform. On Windows
   // stack slots are reserved for the arguments passed in registers. On other
   // platforms stack slots are only reserved for the arguments actually passed
   // on the stack.
   void PrepareCallCFunction(int num_arguments);
 
@@ skipping 849 matching lines @@
       Jump(adaptor, RelocInfo::CODE_TARGET);
     }
     bind(&invoke);
   }
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_X64_MACRO_ASSEMBLER_X64_H_