Issue 4693005: Set the download rate to 0B/s if the download is paused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4693005: Set the download rate to 0B/s if the download is paused. (Closed)

Created:
10 years, 1 month ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
kochi, Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser

Visibility:
Public.

Description

Set the download rate to 0B/s if the download is paused. BUG=chromium-os:2287 TEST=Download a large file. Pause the download. Check that the rate changes to 0B/s Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65642

Patch Set 1 #

Patch Set 2 : Code review #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/download/download_util.cc	View		1 chunk	+10 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years, 1 month ago (2010-11-10 12:14:01 UTC) #3

Drive-by with a download comment. Please do a follow-up CL.

http://codereview.chromium.org/4693005/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/4693005/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:586: if (download->is_paused()) {
This seems wrong. Why not do that in download->CurrentSpeed()?

Expand Messages | Collapse Messages