base/crypto/symmetric_key.h - Issue 4691003: Implement symmetric key for openssl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/crypto/symmetric_key.h

Issue 4691003: Implement symmetric key for openssl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactored tests to parameterized style, and working Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/crypto/symmetric_key.h

diff --git a/base/crypto/symmetric_key.h b/base/crypto/symmetric_key.h

index 3f2be76390c7188a5ec446dd1a79aa95b575f1ab..cc75612cd33d317d49a9ec5476d2a924292cb42b 100644

--- a/base/crypto/symmetric_key.h

+++ b/base/crypto/symmetric_key.h

@@ -66,8 +66,9 @@ class SymmetricKey {

private:

#if defined(USE_OPENSSL)

- // TODO(joth): Add a constructor that accepts OpenSSL symmetric key data, and

- // the appropriate data members to store it in.

+ // Swaps in the content of the |key|.

+ SymmetricKey(std::string* key);

Ryan Sleevi 2010/11/10 23:18:46 Ctor should be marked explicit.

joth 2010/11/11 15:07:12 Done.

+ std::string key_;

#elif defined(USE_NSS)

explicit SymmetricKey(PK11SymKey* key);

ScopedPK11SymKey key_;

« no previous file with comments | « no previous file | base/crypto/symmetric_key_openssl.cc » ('j') | base/crypto/symmetric_key_openssl.cc » ('J')