Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 4691001: Make GConf dependency optional. (Closed)

Created:
10 years, 1 month ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman, Elliot Glaysher
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Make GConf dependency optional. This is upstreaming a Gentoo Linux patch. BUG=13322 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/gtk/browser_titlebar.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/gtk/gconf_titlebar_listener.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 1 month ago (2010-11-08 15:34:15 UTC) #1
Elliot Glaysher
LGTM
10 years, 1 month ago (2010-11-08 17:49:17 UTC) #2
eroman
10 years, 1 month ago (2010-11-08 21:03:35 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698