chrome_frame/chrome_frame_activex_base.h - Issue 4690004: Popup windows launched in a new window in ChromeFrame on IE8 would open behin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/chrome_frame_activex_base.h

Issue 4690004: Popup windows launched in a new window in ChromeFrame on IE8 would open behin... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/chrome_frame_activex_base.h

===================================================================

--- chrome_frame/chrome_frame_activex_base.h (revision 65344)

+++ chrome_frame/chrome_frame_activex_base.h (working copy)

@@ -506,7 +506,7 @@

}

std::string url = base::StringPrintf(

- "%hs:%hs?attach_external_tab&%I64u&%d&%d&%d&%d&%d&%hs",

+ "%hs://%hs?attach_external_tab&%I64u&%d&%d&%d&%d&%d&%hs",

amit 2010/11/09 22:47:54 Looks like this will convert gcf:attach... to gcf:

scheme.c_str(),

host.c_str(),

params.cookie,

« no previous file with comments | « chrome_frame/chrome_active_document.cc ('k') | no next file » | no next file with comments »