Issue 4690004: Popup windows launched in a new window in ChromeFrame on IE8 would open behin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4690004: Popup windows launched in a new window in ChromeFrame on IE8 would open behin... (Closed)

Created:
10 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Popup windows launched in a new window in ChromeFrame on IE8 would open behind and would not render any content until the user clicked on them. This is because in this context IE8 attempts to inplace activate the object with the active document as the doc host. We don't support in place activation and return E_NOTIMPL. However ieframe specifically expects the return value to be OLEOBJ_E_INVALIDVERB and ends up not sending in the other verbs like OLEIVERB_SHOW, OLEIVERB_UIACTIVATE etc leading to this problem. Fixes bug http://b/issue?id=3174688 Bug=3174688 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65595

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome_frame/chrome_active_document.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome_frame/chrome_frame_activex_base.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 1 month ago (2010-11-09 22:47:54 UTC) #2

Nice find, LGTM!

http://codereview.chromium.org/4690004/diff/1/chrome_frame/chrome_frame_activ...
File chrome_frame/chrome_frame_activex_base.h (right):

http://codereview.chromium.org/4690004/diff/1/chrome_frame/chrome_frame_activ...
chrome_frame/chrome_frame_activex_base.h:509:
"%hs://%hs?attach_external_tab&%I64u&%d&%d&%d&%d&%d&%hs",
Looks like this will convert gcf:attach... to gcf://attach... is this intended,
related to other changes?

Expand Messages | Collapse Messages