Track permissions granted to extensions in prefs

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
@@ skipping 276 matching lines @@
 
   // Forbid options page with non-(http|https) scheme in hosted app.
   LoadAndExpectError("hosted_app_file_options.json",
                      errors::kInvalidOptionsPageInHostedApp);
 
   // Forbid absolute URL for options page in packaged apps.
   LoadAndExpectError("packaged_app_absolute_options.json",
                      errors::kInvalidOptionsPageExpectUrlInPackage);
 }
 
-TEST_F(ExtensionManifestTest, DisallowExtensionPermissions) {
+TEST_F(ExtensionManifestTest, AllowUnrecognizedPermissions) {
   std::string error;
   scoped_ptr<DictionaryValue> manifest(
       LoadManifestFile("valid_app.json", &error));
   ASSERT_TRUE(manifest.get());
 
   ListValue *permissions = new ListValue();
   manifest->Set(keys::kPermissions, permissions);
   for (size_t i = 0; i < Extension::kNumPermissions; i++) {
     const char* name = Extension::kPermissions[i].name;
     StringValue* p = new StringValue(name);
     permissions->Clear();
     permissions->Append(p);
     std::string message_name = base::StringPrintf("permission-%s", name);
-    if (Extension::IsHostedAppPermission(name)) {
-      scoped_refptr<Extension> extension;
-      extension = LoadAndExpectSuccess(manifest.get(), message_name);
-    } else {
-      LoadAndExpectError(manifest.get(), message_name,
-                         errors::kInvalidPermission);
-    }
+
+    // Extensions are allowed to contain unrecognized API permissions,
+    // so there shouldn't be any errors.
+    scoped_refptr<Extension> extension;
+    extension = LoadAndExpectSuccess(manifest.get(), message_name);
   }
 }
 
 TEST_F(ExtensionManifestTest, NormalizeIconPaths) {
   scoped_refptr<Extension> extension(
       LoadAndExpectSuccess("normalize_icon_paths.json"));
   EXPECT_EQ("16.png",
             extension->icons().Get(16, ExtensionIconSet::MATCH_EXACTLY));
   EXPECT_EQ("48.png",
             extension->icons().Get(48, ExtensionIconSet::MATCH_EXACTLY));
@@ skipping 32 matching lines @@
 
 TEST_F(ExtensionManifestTest, DefaultPathForExtent) {
   scoped_refptr<Extension> extension(
       LoadAndExpectSuccess("default_path_for_extent.json"));
 
   ASSERT_EQ(1u, extension->web_extent().patterns().size());
   EXPECT_EQ("/*", extension->web_extent().patterns()[0].path());
   EXPECT_TRUE(extension->web_extent().ContainsURL(
       GURL("http://www.google.com/monkey")));
 }