Track permissions granted to extensions in prefs

chrome/common/extensions/extension_extent.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/logging.h"
 #include "chrome/common/extensions/extension_extent.h"
 
 #include "chrome/common/extensions/url_pattern.h"
 #include "googleurl/src/gurl.h"
 
 ExtensionExtent::ExtensionExtent() {
 }
 
 ExtensionExtent::ExtensionExtent(const ExtensionExtent& rhs)
     : patterns_(rhs.patterns_) {
@@ skipping 36 matching lines @@
        i != patterns_.end(); ++i) {
     for (PatternList::const_iterator j = other.patterns().begin();
          j != other.patterns().end(); ++j) {
       if (i->OverlapsWith(*j))
         return true;
     }
   }
 
   return false;
 }
+
+void ExtensionExtent::GetAsStringSet(

[Aaron Boodman, 2010/11/12 00:05:24]

It seems ugly somehow to pass these around as string sets. Can you push the
details of serializing ExtensionExtents to strings and parsing ExtensionExtents
from strings out to the edges more? I would like to see ExtensionExtent being
passed, eg, to Extension::IsPermissionIncrease(), rather than
std::set<std::string>

Only ExtensionPrefs should have methods that accept and return ExtensionExtents
and it should deal with the parsing internally.

[jstritar, 2010/11/19 21:38:36]

Done. I now have an "AddPattern" helper method in a few different files
(extension_prefs.cc, extension_service_unittest.cc and
extension_prefs_unittest.cc). Is there a good place to put this or should I
leave it copy+pasted?

+    std::set<std::string>* string_patterns) const {
+  DCHECK(string_patterns);
+
+  for (PatternList::const_iterator i = patterns().begin();
+       i != patterns().end(); ++i)
+    string_patterns->insert(i->GetAsString());
+}