Track permissions granted to extensions in prefs

chrome/browser/extensions/extension_prefs.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 100 matching lines @@
   bool IsExtensionAllowedByPolicy(const std::string& extension_id);
 
   // Returns the last value set via SetLastPingDay. If there isn't such a
   // pref, the returned Time will return true for is_null().
   base::Time LastPingDay(const std::string& extension_id) const;
 
   // The time stored is based on the server's perspective of day start time, not
   // the client's.
   void SetLastPingDay(const std::string& extension_id, const base::Time& time);
 
+  // Gets the |api_permissions| and |host_permissions| granted to the extension
+  // with |extension_id|. Returns false if no permissions were granted yet.
+  bool GetGrantedPermissions(const std::string& extension_id,
+                             std::set<std::string>* api_permissions,
+                             std::set<std::string>* host_permissions);
+
+  // Grants the specified |api_permissions| and |host_permissions|
+  // to the extension with |extension_id|.
+  void GrantPermissions(const std::string& extension_id,

[Aaron Boodman, 2010/11/12 00:05:24]

Nit: how about "SetLastGrantedPermissions" and "GetLastGrantedPermissions". It's
a minor change, but the verb "grant" to me sounds like this doing more than what
it actually is doing. Also update the comments to match.

[jstritar, 2010/11/19 21:38:36]

I didn't include "Last" in the name since these hold the maximum set of
permissions granted to the extension (it performs a union), so that extensions
can remove a permission in one version, then add it back without prompting the
user. I updated the names to GetGrantedPermissions and AddGrantedPermissions.

[Aaron Boodman, 2010/11/22 07:57:53]

Neat!

+                        const std::set<std::string>& api_permissions,
+                        const std::set<std::string>& host_permissions);
+
   // Similar to the 2 above, but for the extensions blacklist.
   base::Time BlacklistLastPingDay() const;
   void SetBlacklistLastPingDay(const base::Time& time);
 
   // Returns true if the user enabled this extension to be loaded in incognito
   // mode.
   bool IsIncognitoEnabled(const std::string& extension_id);
   void SetIsIncognitoEnabled(const std::string& extension_id, bool enabled);
 
   // Returns true if the user has chosen to allow this extension to inject
@@ skipping 72 matching lines @@
 
   // Sets the pref |key| for extension |id| to |value|.
   void UpdateExtensionPref(const std::string& id,
                            const std::string& key,
                            Value* value);
 
   // Deletes the pref dictionary for extension |id|.
   void DeleteExtensionPrefs(const std::string& id);
 
   // Reads a boolean pref from |ext| with key |pref_key|.
-  // Return false if the value is false or kPrefBlacklist does not exist.
+  // Return false if the value is false or |pref_key| does not exist.
   bool ReadBooleanFromPref(DictionaryValue* ext, const std::string& pref_key);
 
   // Reads a boolean pref |pref_key| from extension with id |extension_id|.
   bool ReadExtensionPrefBoolean(const std::string& extension_id,
                                 const std::string& pref_key);
 
   // Reads an integer pref from |ext| with key |pref_key|.
   // Return false if the value does not exist.
   bool ReadIntegerFromPref(DictionaryValue* ext, const std::string& pref_key,
                            int* out_value);
 
   // Reads an integer pref |pref_key| from extension with id |extension_id|.
   bool ReadExtensionPrefInteger(const std::string& extension_id,
                                 const std::string& pref_key,
                                 int* out_value);
 
+  // Reads a list pref |pref_key| from extension with id | extension_id|.
+  bool ReadExtensionPrefList(const std::string& extension_id,
+                             const std::string& pref_key,
+                             ListValue** out_value);
+
+  // Reads a list pref |pref_key| as a string set from the extension with
+  // id |extension_id|.
+  bool ReadExtensionPrefStringSet(const std::string& extension_id,
+                                  const std::string& pref_key,
+                                  std::set<std::string>* result);
+
+  // Adds the |added_values| to the list preference at |pref_key| for the
+  // extension with id |extension_id|.
+  void AddToExtensionPrefStringSet(const std::string& extension_id,
+                                   const std::string& pref_key,
+                                   const std::set<std::string>& added_values);
+
   // Ensures and returns a mutable dictionary for extension |id|'s prefs.
   DictionaryValue* GetOrCreateExtensionPref(const std::string& id);
 
   // Same as above, but returns NULL if it doesn't exist.
   DictionaryValue* GetExtensionPref(const std::string& id) const;
 
   // Serializes the data and schedules a persistent save via the |PrefService|.
   // Additionally fires a PREF_CHANGED notification with the top-level
   // |kExtensionsPref| path set.
   // TODO(andybons): Switch this to EXTENSION_PREF_CHANGED to be more granular.
@@ skipping 16 matching lines @@
   // Base extensions install directory.
   FilePath install_directory_;
 
   // The URLs of all of the toolstrips.
   URLList shelf_order_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_H_