Issue 4687001: Add comments to double.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4687001: Add comments to double.h. (Closed)

Created:
10 years, 1 month ago by Florian Loitsch

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add comments to double.h. Committed: http://code.google.com/p/v8/source/detail?r=5789

Patch Set 2 : Forgot a comment. #

Total comments: 4

Patch Set 3 : Adressed comments. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	src/double.h	View	1 2	3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM, with comments. http://codereview.chromium.org/4687001/diff/3001/4001 File src/double.h (right): http://codereview.chromium.org/4687001/diff/3001/4001#newcode65 src/double.h:65: // The value encode by this ...

10 years, 1 month ago (2010-11-08 15:35:44 UTC) #2

Florian Loitsch

10 years, 1 month ago (2010-11-08 15:40:24 UTC) #3

http://codereview.chromium.org/4687001/diff/3001/4001
File src/double.h (right):

http://codereview.chromium.org/4687001/diff/3001/4001#newcode65
src/double.h:65: // The value encode by this Double must be strictly greater
than 0.
On 2010/11/08 15:35:44, William Hesse wrote:
> encoded

Done.

http://codereview.chromium.org/4687001/diff/3001/4001#newcode87
src/double.h:87: // Returns the next greater double. Infinity returns infinity.
On 2010/11/08 15:35:44, William Hesse wrote:
> Returns +infinity on input +infinity.

Done.