Issue 4685001: Update v8 to version 2.5.5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4685001: Update v8 to version 2.5.5. (Closed)

Created:
10 years, 1 month ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update v8 to version 2.5.5. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65374

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

10 years, 1 month ago (2010-11-08 14:55:47 UTC) #2

LGTM.

On Mon, Nov 8, 2010 at 3:54 PM, <whesse@chromium.org> wrote:

> Reviewers: Kevin Millikin,
>
> Description:
> Update v8 to version 2.5.5.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/4685001/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 65370)
> +++ DEPS        (working copy)
> @@ -58,7 +58,7 @@
>     (Var("googlecode_url") % "gyp") + "/trunk@856",
>
>   "src/v8":
> -    (Var("googlecode_url") % "v8") + "/trunk@5757",
> +    (Var("googlecode_url") % "v8") + "/trunk@5780",
>
>   "src/native_client":
>     Var("nacl_trunk") + "/src/native_client@" + Var("nacl_revision"),
>
>
>

Expand Messages | Collapse Messages