Issue 4681003: Heap profiler: remove context checks for objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4681003: Heap profiler: remove context checks for objects. (Closed)

Created:
10 years, 1 month ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Heap profiler: remove context checks for objects. It seems that there will be no access to heap snapshots from web pages' code, only from Developer Tools, thus it makes no sense doing filtering of object by their security contexts. Committed: http://code.google.com/p/v8/source/detail?r=5787

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -62 lines)			Patch
M	src/profile-generator.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/profile-generator.cc	View	2 chunks	+3 lines, -27 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	5 chunks	+2 lines, -33 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages