Issue 4680001: Adding ScopedAllowIO to RLZ until it has been inspected....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4680001: Adding ScopedAllowIO to RLZ until it has been inspected.... (Closed)

Created:
10 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adding ScopedAllowIO to RLZ until it has been inspected. TBR=rogerta BUG=http://crbug.com/62328 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65369

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/rlz/rlz.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Thanks for the fix Finnur. However, don't you need to make the same change to ...

10 years, 1 month ago (2010-11-08 14:40:49 UTC) #2

Finnur

I discovered the Observe one after submitting the fix (see other review). Maybe we should ...

10 years, 1 month ago (2010-11-08 14:44:58 UTC) #3

(NOT FOR CODE REVIEWS)

10 years, 1 month ago (2010-11-08 14:56:29 UTC) #4

lgtm

OK, just saw the other CL.  This CL plus the other one together are lgtm'ed.

Thanks,
Roger

-



On Mon, Nov 8, 2010 at 09:44,  <finnur@chromium.org> wrote:
> I discovered the Observe one after submitting the fix (see other review).
> Maybe
> we should continue this discussion there?
>
> On 2010/11/08 14:40:49, Roger Tawa wrote:
>>
>> Thanks for the fix Finnur.  However, don't you need to make the same
>> change to
>> OmniBoxObserver::Observe() and DailyPingTask::PingNow()?  Both make calls
>> into
>> RLZ which access the registry.
>
>
>
> http://codereview.chromium.org/4680001/show
>

Expand Messages | Collapse Messages