Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 4675003: laptop-mode-tools: switch wifi support to be nl80211-only (Closed)

Created:
10 years, 1 month ago by Sam Leffler
Modified:
9 years, 7 months ago
Reviewers:
Sameer Nanda, Simon Que
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

laptop-mode-tools: switch wifi support to be nl80211-only We support only nl80211 WiFi devices; no more WEXT support: - remove old script that used iwconfig - add new module script that uses iw to ena/dis power save Note this also fixes wifi power save operation for nl80211 devices as the iwconfig code never worked right due to it checking the wrong file under /sys. This means we should now have lower latency on AC because we'll turn off power save. BUG=7138 TEST=gmerge to device; suspend+resume and check power save state of wlan0; also run sh -x laptop_mode auto force and verify the right things are happenig for wifi devices Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c486fbc

Patch Set 1 #

Patch Set 2 : add nl80211-specific script #

Patch Set 3 : remove wext support per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
A + laptop-mode-tools_1.52/usr/share/laptop-mode-tools/modules/wifi-nl80211-powermgmt View 2 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Leffler
Hope you weren't actively working on this; just noticed it while working on related stuff. ...
10 years, 1 month ago (2010-11-10 00:37:30 UTC) #1
Sam Leffler
10 years, 1 month ago (2010-11-10 04:43:30 UTC) #2
Sameer Nanda
LGTM. Feel free to delete wifi-powermgt module. It was added by us and doesn't exist ...
10 years, 1 month ago (2010-11-10 17:48:38 UTC) #3
Sam Leffler
10 years, 1 month ago (2010-11-10 18:22:21 UTC) #4
Removed iwconfig-based support and fixed issue before push.  Thank you!

Powered by Google App Engine
This is Rietveld 408576698