Issue 4675001: Don't run SSLClientSocketTest tests under Valgrind...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4675001: Don't run SSLClientSocketTest tests under Valgrind... (Closed)

Created:
10 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't run SSLClientSocketTest tests under Valgrind BUG=62314 TEST=Valgrind&TSan mac bots should go green TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65359

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/valgrind/gtest_exclude/net_unittests.gtest.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 1 month ago (2010-11-08 10:24:52 UTC) #2

LGTM

On Mon, Nov 8, 2010 at 1:20 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Don't run SSLClientSocketTest tests under Valgrind
> BUG=62314
> TEST=Valgrind&TSan mac bots should go green
> TBR=glider
>
> Please review this at http://codereview.chromium.org/4675001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/gtest_exclude/net_unittests.gtest.txt
>
>
> Index: tools/valgrind/gtest_exclude/net_unittests.gtest.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/net_unittests.gtest.txt        (revision
> 65356)
> +++ tools/valgrind/gtest_exclude/net_unittests.gtest.txt        (working
> copy)
> @@ -6,4 +6,4 @@
>  SpdyNetworkTransactionTest.PostWithEarlySynReply
>
>  # These tests fail under Valgrind, see http://crbug.com/62314
> -SSLClientSocketTest.Connect*
> +SSLClientSocketTest.*
>
>
>

Expand Messages | Collapse Messages