Issue 4671001: Use less TSan ignores for base/atomic*...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4671001: Use less TSan ignores for base/atomic*... (Closed)

Created:
10 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use less TSan ignores for base/atomic* TEST=TSan bots on the memory waterfall should remain green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65357

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	tools/valgrind/tsan/ignores.txt	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	tools/valgrind/tsan/ignores_mac.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 1 month ago (2010-11-08 09:52:01 UTC) #2

LGTM

On Mon, Nov 8, 2010 at 12:48 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Use less TSan ignores for base/atomic*
> TEST=TSan bots on the memory waterfall should remain green
>
> Please review this at http://codereview.chromium.org/4671001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/tsan/ignores.txt
>  M     tools/valgrind/tsan/ignores_mac.txt
>
>
> Index: tools/valgrind/tsan/ignores.txt
> ===================================================================
> --- tools/valgrind/tsan/ignores.txt     (revision 65355)
> +++ tools/valgrind/tsan/ignores.txt     (working copy)
> @@ -53,12 +53,15 @@
>  ##################################################################
>  # Don't instrument synchronization code
>  src:*base/waitable_event*
> -src:*base/atomic*
>  src:*base/condition_variable*
>  src:*base/lock*
>  src:*base/stats_counters*
>  src:*base/thread_local_storage*
>
> +# Don't instrument code dealing with atomics (base::subtle)
> +fun:*base*subtle*Release_Store*
> +fun:*base*subtle*NoBarrier_CompareAndSwap*
> +
>  # Don't instrument tcmalloc
>  src:*/tcmalloc/*
>
> Index: tools/valgrind/tsan/ignores_mac.txt
> ===================================================================
> --- tools/valgrind/tsan/ignores_mac.txt (revision 65355)
> +++ tools/valgrind/tsan/ignores_mac.txt (working copy)
> @@ -4,12 +4,6 @@
>  # ThreadSanitizer, so we have to define fun:* rules for Mac OS
> complementing
>  # the src:* rules defined for Linux.
>
> -# Don't instrument code dealing with atomics (base::subtle)
> -fun:*base*subtle*NoBarrier_Load*
> -fun:*base*subtle*Release_Store*
> -fun:*base*subtle*NoBarrier_Store*
> -fun:*base*subtle*NoBarrier_CompareAndSwap*
> -
>  # we ignore the Security libraries for now since
>  # their instrumentation is very slow.
>  # TODO(timurrrr): investigate whether we need to instrument them
>
>
>

Expand Messages | Collapse Messages