Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: base/sys_info_unittest.cc

Issue 467053: Fix test failure: SysInfoTest.GoogleChromeOSVersionNumbersFirst (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/sys_info_chromeos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info_unittest.cc
===================================================================
--- base/sys_info_unittest.cc (revision 34061)
+++ base/sys_info_unittest.cc (working copy)
@@ -77,9 +77,9 @@
&os_major_version,
&os_minor_version,
&os_bugfix_version);
- EXPECT_EQ(os_major_version, 1);
- EXPECT_EQ(os_minor_version, 2);
- EXPECT_EQ(os_bugfix_version, 3);
+ EXPECT_EQ(1, os_major_version);
+ EXPECT_EQ(2, os_minor_version);
+ EXPECT_EQ(3, os_bugfix_version);
}
TEST_F(SysInfoTest, GoogleChromeOSVersionNumbersFirst) {
@@ -93,9 +93,9 @@
&os_major_version,
&os_minor_version,
&os_bugfix_version);
- EXPECT_EQ(os_major_version, 1);
- EXPECT_EQ(os_minor_version, 2);
- EXPECT_EQ(os_bugfix_version, 3);
+ EXPECT_EQ(1, os_major_version);
+ EXPECT_EQ(2, os_minor_version);
+ EXPECT_EQ(3, os_bugfix_version);
}
TEST_F(SysInfoTest, GoogleChromeOSNoVersionNumbers) {
@@ -107,9 +107,9 @@
&os_major_version,
&os_minor_version,
&os_bugfix_version);
- EXPECT_EQ(os_major_version, -1);
- EXPECT_EQ(os_minor_version, -1);
- EXPECT_EQ(os_bugfix_version, -1);
+ EXPECT_EQ(-1, os_major_version);
+ EXPECT_EQ(-1, os_minor_version);
+ EXPECT_EQ(-1, os_bugfix_version);
}
#endif // OS_CHROMEOS
« no previous file with comments | « base/sys_info_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698