Change NSS's native auth patch to use PCERT_KEY_CONTEXT instead of HCRYPTPROV on Win

net/third_party/nss/ssl/ssl.h

 /*
  * This file contains prototypes for the public SSL functions.
  *
  * ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
  * http://www.mozilla.org/MPL/
@@ skipping 333 matching lines @@
 /*
  * Prototype for SSL callback to get client auth data from the application,
  * when using the underlying platform's cryptographic primitives. Returning
  * SECFailure will cause the socket to send no client certificate.
  *      arg - application passed argument
  *      caNames - pointer to distinguished names of CAs that the server likes
  *      pRetCerts - pointer to pointer to list of certs, with the first being
  *                  the client cert, and any following being used for chain
  *                  building
  *      pRetKey - pointer to native key pointer, for return of key
- *          - Windows: pointer to HCRYPTPROV
- *          - Mac OS X: pointer to SecKeyRef
+ *          - Windows: A PCERT_KEY_CONTEXT, allocated via PORT_Alloc().

[wtc, 2011/02/04 01:32:16]

This should say "A pointer to PCERT_KEY_CONTEXT", right?

Also, you should clarify that it is CERT_KEY_CONTEXT that
is allocated via PORT_Alloc(), in this comment and in the
Description of the CL.

[Ryan Sleevi, 2011/02/05 04:43:20]

Thanks. Here, it is supposed to be a pointer-to-a-PCERT_KEY_CONTEXT, since it
needs to be a pointer-to-a-pointer. The CL description is correct though, in
that it changes from an HCRYPTPROV to a PCERT_KEY_CONTEXT (that is, a pointer to
a CERT_KEY_CONTEXT), so I left that as is.

+ *                     Ownership will be transferred to NSS, which will free
+ *                     via PORT_Free().
+ *          - Mac OS X: A pointer to a SecKeyRef. Ownership will be
+ *                      transferred to NSS, which will free via CFRelease().
  */
 typedef SECStatus (PR_CALLBACK *SSLGetPlatformClientAuthData)(void *arg,
                                 PRFileDesc *fd,
                                 CERTDistNames *caNames,
                                 CERTCertList **pRetCerts,/*return */
                                 void **pRetKey);/* return */
 
 /*
  * Set the client side callback for SSL to retrieve user's private key
  * and certificate.
@@ skipping 382 matching lines @@
 ** Did the handshake with the peer negotiate the given extension?
 ** Output parameter valid only if function returns SECSuccess
 */
 SSL_IMPORT SECStatus SSL_HandshakeNegotiatedExtension(PRFileDesc * socket,
                                                       SSLExtensionType extId,
                                                       PRBool *yes);
 
 SEC_END_PROTOS
 
 #endif /* __ssl_h_ */