Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 4665007: gtk: Disable menu icons again. (Closed)

Created:
10 years, 1 month ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-os-reviews_chromium.org, Nathan Williams
Visibility:
Public.

Description

gtk: Disable menu icons again. This re-does my previous change to set gtk-menu-images to 0. I'm going to check in a Chrome change first so that Views menu items with icons will override this setting: http://codereview.chromium.org/4708008/ I'm also leaving out the earlier change to remove horizontal spacing, since it makes the items looked cramped and doesn't get along well with items that still have icons. Still need to find a way to get rid of the excess space on the left of the omnibox menu (might be a GTK+ bug; looks like we're still getting the padding even though the icon is hidden) and the left of the wrench menu. BUG=chromium-os:4345 TEST=built and used it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1147ee5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M resources/gtkrc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
10 years, 1 month ago (2010-11-11 03:16:52 UTC) #1
xiyuan
10 years, 1 month ago (2010-11-11 17:38:52 UTC) #2
LGTM again. :)

Powered by Google App Engine
This is Rietveld 408576698