Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: chrome/test/ui/ui_test.cc

Issue 4662005: Moved --use-gl=osmesa to UITest::SetUp so it is not visible to pyautolib.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.cc
===================================================================
--- chrome/test/ui/ui_test.cc (revision 65604)
+++ chrome/test/ui/ui_test.cc (working copy)
@@ -690,14 +690,6 @@
// Tell the browser to use a temporary directory just for this test.
command_line.AppendSwitchPath(switches::kUserDataDir, user_data_dir());
- // Force tests to use OSMesa if they launch the GPU process.
- command_line.AppendSwitchASCII(switches::kUseGL,
- gfx::kGLImplementationOSMesaName);
-
- // Mac does not support accelerated compositing with OSMesa. Disable on all
- // platforms so it is consistent. http://crbug.com/58343
- command_line.AppendSwitch(switches::kDisableAcceleratedCompositing);
-
// We need cookies on file:// for things like the page cycler.
if (enable_file_cookies_)
command_line.AppendSwitch(switches::kEnableFileCookies);
@@ -846,6 +838,17 @@
set_ui_test_name(test_info->test_case_name() + std::string(".") +
test_info->name());
}
+
+ // Force tests to use OSMesa if they launch the GPU process. This is in
+ // UITest::SetUp so that it does not affect pyautolib, which runs tests that
+ // do not work with OSMesa.
+ launch_arguments_.AppendSwitchASCII(switches::kUseGL,
+ gfx::kGLImplementationOSMesaName);
+
+ // Mac does not support accelerated compositing with OSMesa. Disable on all
+ // platforms so it is consistent. http://crbug.com/58343
+ launch_arguments_.AppendSwitch(switches::kDisableAcceleratedCompositing);
+
UITestBase::SetUp();
PlatformTest::SetUp();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698