Simplified AudioOutputStream interface.

media/audio/audio_io.h

Index: media/audio/audio_io.h
diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h
index 3aa22cf0153c070b51e8df3e7ca8e54b29fd79f7..10176a0685470bbff86d8745ea4fc444a9b605fc 100644
--- a/media/audio/audio_io.h
+++ b/media/audio/audio_io.h
@@ -60,10 +60,6 @@ class AudioOutputStream {
         AudioOutputStream* stream, uint8* dest, uint32 max_size,
         AudioBuffersState buffers_state) = 0;
 
-    // The stream is done with this callback. After this call the audio source
-    // can go away or be destroyed.
-    virtual void OnClose(AudioOutputStream* stream) = 0;
-
     // There was an error while playing a buffer. Audio source cannot be
     // destroyed yet. No direct action needed by the AudioStream, but it is
     // a good place to stop accumulating sound data since is is likely that
@@ -72,17 +68,8 @@ class AudioOutputStream {
     virtual void OnError(AudioOutputStream* stream, int code) = 0;
   };
 
-  // Open the stream. |packet_size| is the requested buffer allocation which
-  // the audio source thinks it can usually fill without blocking. Internally
-  // two or three buffers of |packet_size| size are created, one will be
-  // locked for playback and one will be ready to be filled in the call to
-  // AudioSourceCallback::OnMoreData().
-  // The number of buffers is controlled by AUDIO_PCM_LOW_LATENCY. See more
-  // information below.
-  //
-  // TODO(ajwong): Streams are not reusable, so try to move packet_size into the
-  // constructor.
-  virtual bool Open(uint32 packet_size) = 0;
+  // Open the stream.

[scherkus (not reviewing), 2010/11/09 02:28:31]

so a lot of the comments went away

does it not apply anymore or can we at least be a bit more descriptive here? 
what does returning true/false mean? etc

[Sergey Ulanov, 2010/11/09 22:29:58]

The comments about |packet_size| do not apply anymore because we don't have this
parameter. The paragraph about AUDIO_PCM_LOW_LATENCY was invalid because it was
true only for Windows, on mac and linux you can't create stream with
AUDIO_PCM_LOW_LATENCY (BTW, do we need AUDIO_PCM_LOW_LATENCY at all? It doesn't
seem to be used anywhere)
I've added more comments here and above.

+  virtual bool Open() = 0;
 
   // Starts playing audio and generating AudioSourceCallback::OnMoreData().
   // Since implementor of AudioOutputStream may have internal buffers, right