chrome/renderer/media/audio_renderer_impl.cc - Issue 4661001: Simplified AudioOutputStream interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/media/audio_renderer_impl.cc

Issue 4661001: Simplified AudioOutputStream interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: - Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/media/audio_renderer_impl.cc

diff --git a/chrome/renderer/media/audio_renderer_impl.cc b/chrome/renderer/media/audio_renderer_impl.cc

index f71282cd4cd74b62cc7418f3ece2e4f539ef8d6c..00216560092dd895cc2ee25d03522f9c187ad568 100644

--- a/chrome/renderer/media/audio_renderer_impl.cc

+++ b/chrome/renderer/media/audio_renderer_impl.cc

@@ -255,7 +255,9 @@ void AudioRendererImpl::CreateStreamTask(AudioParameters audio_params) {

ViewHostMsg_Audio_CreateStream_Params params;

params.params = audio_params;

- params.packet_size = 0;

+ // Let the browser choose packet size.

+ params.params.samples_per_packet = 0;

scherkus (not reviewing) 2010/11/09 02:28:31 is this documented anywhere in params or IPC messa

Sergey Ulanov 2010/11/09 22:29:58 Added comments about it in render_messages_params.

filter_->Send(new ViewHostMsg_CreateAudioStream(0, stream_id_, params,

false));