media/audio/simple_sources.h - Issue 4661001: Simplified AudioOutputStream interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/simple_sources.h

Issue 4661001: Simplified AudioOutputStream interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed all comments Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/simple_sources.h

diff --git a/media/audio/simple_sources.h b/media/audio/simple_sources.h

index 4f4dc0757fa4ed26c35b2c062cfc8eace2d337d3..dec839d59128bfcac2143724e3f8345d60c5e61d 100644

--- a/media/audio/simple_sources.h

+++ b/media/audio/simple_sources.h

@@ -29,7 +29,6 @@ class SineWaveAudioSource : public AudioOutputStream::AudioSourceCallback {

virtual uint32 OnMoreData(

AudioOutputStream* stream, uint8* dest, uint32 max_size,

AudioBuffersState audio_buffers);

- virtual void OnClose(AudioOutputStream* stream);

virtual void OnError(AudioOutputStream* stream, int code);

protected:

@@ -73,7 +72,6 @@ class PushSource : public AudioOutputStream::AudioSourceCallback,

// Implementation of AudioSourceCallback.

virtual uint32 OnMoreData(AudioOutputStream* stream, uint8* dest,

uint32 max_size, AudioBuffersState buffers_state);

- virtual void OnClose(AudioOutputStream* stream);

virtual void OnError(AudioOutputStream* stream, int code);

// Discard all buffered data and reset to initial state.