Issue 466089: Link the following tests against tcmalloc:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466089: Link the following tests against tcmalloc:... (Closed)

Created:
11 years ago by not_the_right_glider

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko, willchan no longer on Chromium

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, jam, pam+watch_chromium.org, awong, darin (slow to review), scherkus (not reviewing), Timur Iskhodzhanov

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Link the following tests against tcmalloc: app_unittests browser_tests startup_tests media_unittests printing_unittests net_unittests googleurl_unittests ipc_tests unit_tests ui_tests

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -6 lines)			Patch
M	app/app.gyp	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	build/temp_gyp/googleurl.gyp	View	1 2 3 4 5	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	4 chunks	+36 lines, -0 lines	0 comments	Download
M	ipc/ipc.gyp	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	media/media.gyp	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/net.gyp	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	printing/printing.gyp	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	1 2 3 4 5	2 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM, just fix the formatting to be consistent with the rest of the .gyp files ...

11 years ago (2009-12-09 16:54:40 UTC) #2

Alexander Potapenko

11 years ago (2009-12-10 12:45:16 UTC) #4

On 2009/12/09 17:58:55, not_the_right_glider wrote:
> Fixed.

Committed as http://codereview.chromium.org/488004

Expand Messages | Collapse Messages