linux: theme scrollbars from GTK theme ...

linux: theme scrollbars from GTK theme 

Pick the color of the slider's thumbpart and rail from the GTK theme. 
We cannot match the exact visual appearance of the GTK theme, as 
rendering engines can make arbitrary changes to the actual visual 
appearance. But by sampling a representative set of pixels, we ensure 
that we will at least match the general color scheme. 

BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34183

[Evan Stade, 2009-12-09 00:15:42]

only change to markus's patch is to move renderer pref initialization to its own
file in browser/

[Evan Stade, 2009-12-09 00:31:07]

Markus, does this need to wait for the Webkit side to be rolled, or can we land
it beforehand? It compiles for me locally but fails on the buildbot, so I'm
confused.

[Markus (顧孟勤), 2009-12-09 00:33:57]

It shouldn't even compile unless you have the WebKit changes.

They are in the process of getting picked up by our tree, but I am not sure
whether they are in yet at this very moment.

Should be easy to check, though. Do you have setScrollbarColors() in
RenderThemeChromiumLinux.cpp? Is this a file that you modified locally (that
would explain, why it compiles for you but not on the buildbots).


Markus

[Evan Stade, 2009-12-09 00:38:10]

On Tue, Dec 8, 2009 at 4:33 PM, Markus Gutschke <markus@chromium.org> wrote:

> It shouldn't even compile unless you have the WebKit changes.
>
> They are in the process of getting picked up by our tree, but I am not sure
> whether they are in yet at this very moment.
>
> Should be easy to check, though. Do you have setScrollbarColors() in
> RenderThemeChromiumLinux.cpp? Is this a file that you modified locally (that
> would explain, why it compiles for you but not on the buildbots).
>

oh yeah, you are right... how did you manage to stuff changes to
third_party/ into the original cl?


>
>
> Markus
>

[Markus (顧孟勤), 2009-12-09 00:41:00]

On Tue, Dec 8, 2009 at 16:37, Evan Stade <estade@chromium.org> wrote:

> oh yeah, you are right... how did you manage to stuff changes to
> third_party/ into the original cl?
>

I didn't expect the original changelist to ever get submitted as such, but I
needed a place where I could have people review the changelist in its
entirety. So, I just added all the files to the changelist.

"gcl" won't let you do that. But it is perfectly happy, if you manually edit
the little change description file that it creates. It will then do the
right thing going forward.

I guess, I should have included a big warning :-)


Markus

[Evan Stade, 2009-12-09 00:47:05]

On Tue, Dec 8, 2009 at 4:40 PM, Markus Gutschke <markus@chromium.org> wrote:

> On Tue, Dec 8, 2009 at 16:37, Evan Stade <estade@chromium.org> wrote:
>
>> oh yeah, you are right... how did you manage to stuff changes to
>> third_party/ into the original cl?
>>
>
> I didn't expect the original changelist to ever get submitted as such, but
> I needed a place where I could have people review the changelist in its
> entirety. So, I just added all the files to the changelist.
>
> "gcl" won't let you do that. But it is perfectly happy, if you manually
> edit the little change description file that it creates. It will then do the
> right thing going forward.
>

good to know


>
> I guess, I should have included a big warning :-)
>

no, it was helpful, thanks


>
>
> Markus
>