Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/compiler.cc

Issue 466056: Adding ThisFunction expression to top-level compiler. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/fast-codegen-arm.cc ('k') | src/fast-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 CodeGenSelector::CodeGenTag CodeGenSelector::Select(FunctionLiteral* fun) { 589 CodeGenSelector::CodeGenTag CodeGenSelector::Select(FunctionLiteral* fun) {
590 Scope* scope = fun->scope(); 590 Scope* scope = fun->scope();
591 591
592 if (scope->num_heap_slots() > 0) { 592 if (scope->num_heap_slots() > 0) {
593 // We support functions with a local context if they do not have 593 // We support functions with a local context if they do not have
594 // parameters that need to be copied into the context. 594 // parameters that need to be copied into the context.
595 for (int i = 0, len = scope->num_parameters(); i < len; i++) { 595 for (int i = 0, len = scope->num_parameters(); i < len; i++) {
596 Slot* slot = scope->parameter(i)->slot(); 596 Slot* slot = scope->parameter(i)->slot();
597 if (slot != NULL && slot->type() == Slot::CONTEXT) { 597 if (slot != NULL && slot->type() == Slot::CONTEXT) {
598 if (FLAG_trace_bailout) { 598 if (FLAG_trace_bailout) {
599 PrintF("function has context-allocated parameters"); 599 PrintF("Function has context-allocated parameters.\n");
Kevin Millikin (Chromium) 2009/12/07 14:54:55 When I started this, bailouts were consistently no
fschneider 2009/12/07 15:09:18 Oh ok :) Still, the missing new-line should be th
600 } 600 }
601 return NORMAL; 601 return NORMAL;
602 } 602 }
603 } 603 }
604 } 604 }
605 605
606 has_supported_syntax_ = true; 606 has_supported_syntax_ = true;
607 VisitDeclarations(scope->declarations()); 607 VisitDeclarations(scope->declarations());
608 if (!has_supported_syntax_) return NORMAL; 608 if (!has_supported_syntax_) return NORMAL;
609 609
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 1104
1105 1105
1106 void CodeGenSelector::VisitCompareOperation(CompareOperation* expr) { 1106 void CodeGenSelector::VisitCompareOperation(CompareOperation* expr) {
1107 ProcessExpression(expr->left(), Expression::kValue); 1107 ProcessExpression(expr->left(), Expression::kValue);
1108 CHECK_BAILOUT; 1108 CHECK_BAILOUT;
1109 ProcessExpression(expr->right(), Expression::kValue); 1109 ProcessExpression(expr->right(), Expression::kValue);
1110 } 1110 }
1111 1111
1112 1112
1113 void CodeGenSelector::VisitThisFunction(ThisFunction* expr) { 1113 void CodeGenSelector::VisitThisFunction(ThisFunction* expr) {
1114 BAILOUT("ThisFunction"); 1114 // ThisFunction is supported.
1115 } 1115 }
1116 1116
1117 #undef BAILOUT 1117 #undef BAILOUT
1118 #undef CHECK_BAILOUT 1118 #undef CHECK_BAILOUT
1119 1119
1120 1120
1121 } } // namespace v8::internal 1121 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/fast-codegen-arm.cc ('k') | src/fast-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698