Issue 466056: Adding ThisFunction expression to top-level compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466056: Adding ThisFunction expression to top-level compiler. (Closed)

Created:
11 years ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Adding ThisFunction expression to top-level compiler. Committed: http://code.google.com/p/v8/source/detail?r=3430

Patch Set 3 : '' #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -7 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler.cc	View		2 chunks	+2 lines, -2 lines	2 comments	Download
M	src/fast-codegen.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/ia32/fast-codegen-ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/fast-codegen-x64.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	test/mjsunit/compiler/thisfunction.js	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/466056/diff/5002/5004 File src/compiler.cc (right): http://codereview.chromium.org/466056/diff/5002/5004#newcode599 src/compiler.cc:599: PrintF("Function has context-allocated parameters.\n"); When I started this, ...

11 years ago (2009-12-07 14:54:55 UTC) #2

fschneider

11 years ago (2009-12-07 15:09:17 UTC) #3

http://codereview.chromium.org/466056/diff/5002/5004
File src/compiler.cc (right):

http://codereview.chromium.org/466056/diff/5002/5004#newcode599
src/compiler.cc:599: PrintF("Function has context-allocated parameters.\n");
On 2009/12/07 14:54:55, Kevin Millikin wrote:
> When I started this, bailouts were consistently not complete sentences
> (lowercase, no period).
> 
> It's not consistent now, but it's still the common case.  No reason to change
> just this one :)

Oh ok :)

Still, the missing new-line should be there.

Expand Messages | Collapse Messages

Issue 466056: Adding ThisFunction expression to top-level compiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages