Don't show tabbed options page in OTR browser window.

chrome/browser/gtk/tabs/tab_strip_gtk.cc

Index: chrome/browser/gtk/tabs/tab_strip_gtk.cc
diff --git a/chrome/browser/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/gtk/tabs/tab_strip_gtk.cc
index 054781546e5be01867fa69f0cf684af4c30856c2..027b1ba334ce3b608df4cd2163f7b72108e9f852 100644
--- a/chrome/browser/gtk/tabs/tab_strip_gtk.cc
+++ b/chrome/browser/gtk/tabs/tab_strip_gtk.cc
@@ -12,6 +12,7 @@
 #include "base/i18n/rtl.h"
 #include "base/string_util.h"
 #include "chrome/browser/autocomplete/autocomplete.h"
+#include "chrome/browser/browser.h"
 #include "chrome/browser/gtk/browser_window_gtk.h"
 #include "chrome/browser/gtk/custom_button.h"
 #include "chrome/browser/gtk/gtk_theme_provider.h"
@@ -1974,19 +1975,13 @@ void TabStripGtk::OnNewTabClicked(GtkWidget* widget) {
       if (!gtk_util::URLFromPrimarySelection(model_->profile(), &url))
         return;
 
-      TabContents* contents =
-          model_->delegate()->CreateTabContentsForURL(
-              url,
-              GURL(),  // referrer
-              model_->profile(),
-              PageTransition::TYPED,
-              false,   // defer_load
-              NULL);   // instance
-      model_->AddTabContents(
-          contents,
-          -1,     // index
-          PageTransition::TYPED,
-          TabStripModel::ADD_SELECTED);
+      Browser* browser = window_->browser();
+      if (!browser) {

[Peter Kasting, 2010/11/12 19:49:01]

Nit: Just DCHECK(browser) and keep going.  ("Don't handle DCHECK failures")

[Evan Stade, 2010/11/12 20:47:12]

Done.

+        NOTREACHED();
+        break;
+      }
+
+      browser->AddSelectedTabWithURL(url, PageTransition::TYPED);

[Peter Kasting, 2010/11/12 19:49:01]

This should actually be LINK rather than TYPED (the old code was wrong).

[Evan Stade, 2010/11/12 20:47:12]

Done.

       break;
     }
     default: