Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: media/base/filters.h

Issue 4653005: Move FilterType into MediaFilterCollection (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed windows build buster & presubmit check failure Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | media/base/filters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index bec7d39d5c20995d5e301ce7d95d9a5e0e0bd012..8c3d7571c9f2999a22a75d54527aac56c0506c3e 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -43,18 +43,6 @@ class DemuxerStream;
class FilterHost;
class MediaFilter;
-// Identifies the type of filter implementation. Each filter has to be one of
-// the following types. This is used to identify filter object during
-// initialization of pipeline.
-enum FilterType {
- FILTER_DATA_SOURCE,
- FILTER_DEMUXER,
- FILTER_AUDIO_DECODER,
- FILTER_VIDEO_DECODER,
- FILTER_AUDIO_RENDERER,
- FILTER_VIDEO_RENDERER
-};
-
// Used for completing asynchronous methods.
typedef Callback0::Type FilterCallback;
@@ -62,10 +50,6 @@ class MediaFilter : public base::RefCountedThreadSafe<MediaFilter> {
public:
MediaFilter();
- // Return the type of this filter. All implementor has to provide this
- // method.
- virtual FilterType filter_type() const = 0;
-
// Return the major mime type for this filter.
virtual const char* major_mime_type() const;
@@ -146,9 +130,6 @@ class DataSource : public MediaFilter {
virtual bool IsUrlSupported(const std::string& url);
- static FilterType static_filter_type() { return FILTER_DATA_SOURCE; }
- virtual FilterType filter_type() const;
-
// Initialize a DataSource for the given URL, executing the callback upon
// completion.
virtual void Initialize(const std::string& url, FilterCallback* callback) = 0;
@@ -173,9 +154,6 @@ class DataSource : public MediaFilter {
class Demuxer : public MediaFilter {
public:
- static FilterType static_filter_type() { return FILTER_DEMUXER; }
- virtual FilterType filter_type() const;
-
virtual bool requires_message_loop() const;
virtual const char* message_loop_name() const;
@@ -232,9 +210,6 @@ class DemuxerStream : public base::RefCountedThreadSafe<DemuxerStream> {
class VideoDecoder : public MediaFilter {
public:
- static FilterType static_filter_type() { return FILTER_VIDEO_DECODER; }
- virtual FilterType filter_type() const;
-
virtual const char* major_mime_type() const;
virtual bool requires_message_loop() const;
virtual const char* message_loop_name() const;
@@ -280,9 +255,6 @@ class VideoDecoder : public MediaFilter {
class AudioDecoder : public MediaFilter {
public:
- static FilterType static_filter_type() { return FILTER_AUDIO_DECODER; }
- virtual FilterType filter_type() const;
-
virtual const char* major_mime_type() const;
virtual bool requires_message_loop() const;
virtual const char* message_loop_name() const;
@@ -322,9 +294,6 @@ class AudioDecoder : public MediaFilter {
class VideoRenderer : public MediaFilter {
public:
- static FilterType static_filter_type() { return FILTER_VIDEO_RENDERER; }
- virtual FilterType filter_type() const;
-
virtual const char* major_mime_type() const;
// Initialize a VideoRenderer with the given VideoDecoder, executing the
@@ -339,9 +308,6 @@ class VideoRenderer : public MediaFilter {
class AudioRenderer : public MediaFilter {
public:
- static FilterType static_filter_type() { return FILTER_AUDIO_RENDERER; }
- virtual FilterType filter_type() const;
-
virtual const char* major_mime_type() const;
// Initialize a AudioRenderer with the given AudioDecoder, executing the
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | media/base/filters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698