Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: media/base/media_filter_collection.cc

Issue 4653005: Move FilterType into MediaFilterCollection (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed windows build buster & presubmit check failure Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/base/media_filter_collection.h ('k') | media/base/media_filter_collection_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/media_filter_collection.h" 5 #include "media/base/media_filter_collection.h"
6 6
7 namespace media { 7 namespace media {
8 8
9 MediaFilterCollection::MediaFilterCollection() { 9 MediaFilterCollection::MediaFilterCollection() {
10 } 10 }
11 11
12 void MediaFilterCollection::AddFilter(MediaFilter* filter) { 12 void MediaFilterCollection::AddDataSource(DataSource* filter) {
13 filters_.push_back(filter); 13 AddFilter(DATA_SOURCE, filter);
14 }
15
16 void MediaFilterCollection::AddDemuxer(Demuxer* filter) {
17 AddFilter(DEMUXER, filter);
18 }
19
20 void MediaFilterCollection::AddVideoDecoder(VideoDecoder* filter) {
21 AddFilter(VIDEO_DECODER, filter);
22 }
23
24 void MediaFilterCollection::AddAudioDecoder(AudioDecoder* filter) {
25 AddFilter(AUDIO_DECODER, filter);
26 }
27
28 void MediaFilterCollection::AddVideoRenderer(VideoRenderer* filter) {
29 AddFilter(VIDEO_RENDERER, filter);
30 }
31
32 void MediaFilterCollection::AddAudioRenderer(AudioRenderer* filter) {
33 AddFilter(AUDIO_RENDERER, filter);
14 } 34 }
15 35
16 bool MediaFilterCollection::IsEmpty() const { 36 bool MediaFilterCollection::IsEmpty() const {
17 return filters_.empty(); 37 return filters_.empty();
18 } 38 }
19 39
20 void MediaFilterCollection::Clear() { 40 void MediaFilterCollection::Clear() {
21 filters_.clear(); 41 filters_.clear();
22 } 42 }
23 43
44 void MediaFilterCollection::SelectDataSource(
45 scoped_refptr<DataSource>* filter_out) {
46 SelectFilter<DATA_SOURCE>(filter_out);
47 }
48
49 void MediaFilterCollection::SelectDemuxer(scoped_refptr<Demuxer>* filter_out) {
50 SelectFilter<DEMUXER>(filter_out);
51 }
52
53 void MediaFilterCollection::SelectVideoDecoder(
54 scoped_refptr<VideoDecoder>* filter_out) {
55 SelectFilter<VIDEO_DECODER>(filter_out);
56 }
57
58 void MediaFilterCollection::SelectAudioDecoder(
59 scoped_refptr<AudioDecoder>* filter_out) {
60 SelectFilter<AUDIO_DECODER>(filter_out);
61 }
62
63 void MediaFilterCollection::SelectVideoRenderer(
64 scoped_refptr<VideoRenderer>* filter_out) {
65 SelectFilter<VIDEO_RENDERER>(filter_out);
66 }
67
68 void MediaFilterCollection::SelectAudioRenderer(
69 scoped_refptr<AudioRenderer>* filter_out) {
70 SelectFilter<AUDIO_RENDERER>(filter_out);
71 }
72
73 void MediaFilterCollection::AddFilter(FilterType filter_type,
74 MediaFilter* filter) {
75 filters_.push_back(FilterListElement(filter_type, filter));
76 }
77
78 template<MediaFilterCollection::FilterType filter_type, class Filter>
79 void MediaFilterCollection::SelectFilter(scoped_refptr<Filter>* filter_out) {
80 scoped_refptr<MediaFilter> filter;
81 SelectFilter(filter_type, &filter);
82 *filter_out = reinterpret_cast<Filter*>(filter.get());
83 }
84
24 void MediaFilterCollection::SelectFilter( 85 void MediaFilterCollection::SelectFilter(
25 FilterType filter_type, 86 FilterType filter_type,
26 scoped_refptr<MediaFilter>* filter_out) { 87 scoped_refptr<MediaFilter>* filter_out) {
27 88
28 std::list<scoped_refptr<MediaFilter> >::iterator it = filters_.begin(); 89 FilterList::iterator it = filters_.begin();
29 while (it != filters_.end()) { 90 while (it != filters_.end()) {
30 if ((*it)->filter_type() == filter_type) 91 if (it->first == filter_type)
31 break; 92 break;
32 ++it; 93 ++it;
33 } 94 }
34 95
35 if (it != filters_.end()) { 96 if (it != filters_.end()) {
36 *filter_out = it->get(); 97 *filter_out = it->second.get();
37 filters_.erase(it); 98 filters_.erase(it);
38 } 99 }
39 } 100 }
40 101
41 } // namespace media 102 } // namespace media
OLDNEW
« no previous file with comments | « media/base/media_filter_collection.h ('k') | media/base/media_filter_collection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698