Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 4652001: Update expectations for xpdual/moz. (Closed)

Created:
10 years, 1 month ago by chase
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Update expectations for xpdual/moz. - total_op_b went up around r65182, bug for that is 62272 - total_byte_r and total_byte_b went up around r64763, bug for that is 62274. BUG=62272, 62274 TEST=xp perf is green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chase
10 years, 1 month ago (2010-11-07 20:57:26 UTC) #1
nsylvain
lgtm
10 years, 1 month ago (2010-11-08 00:36:20 UTC) #2
Nicolas Sylvain
What does reva and revb do? On Sun, Nov 7, 2010 at 12:57 PM, <chase@chromium.org> ...
10 years, 1 month ago (2010-11-08 00:38:12 UTC) #3
chase
10 years, 1 month ago (2010-11-08 04:44:34 UTC) #4
Good question.  reva/revb are signals to my "update expectations" script.
 It tells the script to download the trace for that data and estimate the
improve/regress based on the values of t and t_ref in that range (or
score/score_ref, etc).

On Sun, Nov 7, 2010 at 16:37, Nicolas Sylvain <nsylvain@chromium.org> wrote:

> What does reva and revb do?
>
>
> On Sun, Nov 7, 2010 at 12:57 PM, <chase@chromium.org> wrote:
>
>> Reviewers: Nicolas Sylvain,
>>
>> Description:
>> Update expectations for xpdual/moz.
>>
>>  - total_op_b went up around r65182, bug for that
>>    is 62272
>>
>>  - total_byte_r and total_byte_b went up around r64763,
>>    bug for that is 62274.
>>
>> BUG=62272, 62274
>> TEST=xp perf is green
>> TBR=nsylvain@chromium.org
>>
>> Please review this at http://codereview.chromium.org/4652001/show
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/tools/perf_expectations
>>
>> Affected files:
>>  M tools/perf_expectations/perf_expectations.json
>>
>>
>> Index: tools/perf_expectations/perf_expectations.json
>> diff --git a/tools/perf_expectations/perf_expectations.json
>> b/tools/perf_expectations/perf_expectations.json
>> index
>>
a3b4cf5f6f8da0dadea1e5bb7247ee81c9bcb357..eb6f0679ced35966566e76e2a50e133162defaae
>> 100644
>> --- a/tools/perf_expectations/perf_expectations.json
>> +++ b/tools/perf_expectations/perf_expectations.json
>> @@ -65,9 +65,9 @@
>>  "xp-release-dual-core/intl2/times/t": {"improve": 30, "regress": 150},
>>  "xp-release-dual-core/morejs/times/t": {"reva": 63167, "revb": 63335,
>> "improve": -107, "regress": -68},
>>  "xp-release-dual-core/moz/times/t": {"reva": 63120, "revb": 63335,
>> "improve": 40, "regress": 91},
>> - "xp-release-dual-core/moz/total_byte_b/IO_b": {"improve": -6389,
>> "regress": -5607},
>> - "xp-release-dual-core/moz/total_byte_r/IO_r": {"reva": 63063, "revb":
>> 63328, "improve": -96, "regress": 236},
>> - "xp-release-dual-core/moz/total_op_b/IO_op_b": {"reva": 63656, "revb":
>> 64027, "improve": -9251, "regress": -7332},
>> + "xp-release-dual-core/moz/total_byte_b/IO_b": {"reva": 64763, "revb":
>> 65342, "improve": -6624, "regress": -5022},
>> + "xp-release-dual-core/moz/total_byte_r/IO_r": {"reva": 64763, "revb":
>> 65342, "improve": 263, "regress": 688},
>> + "xp-release-dual-core/moz/total_op_b/IO_op_b": {"reva": 65182, "revb":
>> 65342, "improve": -8468, "regress": -6596},
>>  "xp-release-dual-core/moz/total_op_r/IO_op_r": {"improve": -880,
>> "regress": 2130},
>>  "xp-release-dual-core/moz/vm_peak_b/vm_pk_b": {"improve": 600000,
>> "regress": 4200000},
>>  "xp-release-dual-core/moz/vm_peak_r/vm_pk_r": {"reva": 63660, "revb":
>> 64027, "improve": -14949581, "regress": -7358259},
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698