Create literal boilerplate as part of cloning in the top-level compiler....

Create literal boilerplate as part of cloning in the top-level compiler.

When generating code for object and array literals we performed
the check if the a boilerplate already exists in generated code.

In the top-level compiler we now do this check in a new runtime
function. This makes the generated code more compact for top-level code.



Committed: http://code.google.com/p/v8/source/detail?r=3437

[Kevin Millikin (Chromium), 2009-12-09 12:50:07]

LGTM.

You should use the checked (in DEBUG builds) cast operator.

http://codereview.chromium.org/465148/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/465148/diff/1/2#newcode659
src/ia32/fast-codegen-ia32.cc:659: // Registers will be used as follows:
This comment seems unnecessary (and no longer accurate).

http://codereview.chromium.org/465148/diff/1/2#newcode666
src/ia32/fast-codegen-ia32.cc:666: __ push(ebx);
Can you just push(FieldOperand(edi, JSFunction::kLiteralsOffset))?

http://codereview.chromium.org/465148/diff/1/2#newcode774
src/ia32/fast-codegen-ia32.cc:774: __ push(ebx);
Same.

http://codereview.chromium.org/465148/diff/1/3
File src/runtime.cc (right):

http://codereview.chromium.org/465148/diff/1/3#newcode416
src/runtime.cc:416: return
DeepCopyBoilerplate(static_cast<JSObject*>(*boilerplate));
Not static_cast<JSObject*>(*boilerplate), but JSObject::cast(*boilerplate).

[fschneider, 2009-12-09 13:05:10]

Thanks. 

Comments addressed (also on x64/arm).

http://codereview.chromium.org/465148/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/465148/diff/1/2#newcode659
src/ia32/fast-codegen-ia32.cc:659: // Registers will be used as follows:
On 2009/12/09 12:50:07, Kevin Millikin wrote:
> This comment seems unnecessary (and no longer accurate).

Done.

http://codereview.chromium.org/465148/diff/1/2#newcode666
src/ia32/fast-codegen-ia32.cc:666: __ push(ebx);
On 2009/12/09 12:50:07, Kevin Millikin wrote:
> Can you just push(FieldOperand(edi, JSFunction::kLiteralsOffset))?

Done.

http://codereview.chromium.org/465148/diff/1/2#newcode774
src/ia32/fast-codegen-ia32.cc:774: __ push(ebx);
On 2009/12/09 12:50:07, Kevin Millikin wrote:
> Same.

Done.

http://codereview.chromium.org/465148/diff/1/3
File src/runtime.cc (right):

http://codereview.chromium.org/465148/diff/1/3#newcode416
src/runtime.cc:416: return
DeepCopyBoilerplate(static_cast<JSObject*>(*boilerplate));
On 2009/12/09 12:50:07, Kevin Millikin wrote:
> Not static_cast<JSObject*>(*boilerplate), but JSObject::cast(*boilerplate).

Done.