Add linux_valgrind as a default trybot for tools/valgrind/memcheck/ and tcmalloc

Add linux_valgrind as a default trybot for tools/valgrind/memcheck/ and third_party/tcmalloc/

Apart from annoying developers with try mail,
I think this will make some allocation-related changes better tested.
Also, this would help us check the correctness of suppressions (especially, if they are formatted incorrectly).

TEST=try a changelist in tools/valgrind/memcheck/ or third_party/tcmalloc/ and notice linux_valgrind bot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33828

[Timur Iskhodzhanov, 2009-12-04 01:40:26]

Hi,

Can you please review this changelist?

btw, is it possible to avoid runnin win,linux,mac trybots if the
changelist-to-try contains changes only in tools/valgrind/memcheck?

Thank you,
Timur Iskhodzhanov

[M-A Ruel, 2009-12-04 02:10:13]

There is no way to do negative slave. But I would like the functionality so you
should change depot_tools/trychange.py to support that.

Please fix and upload again.

http://codereview.chromium.org/465046/diff/1/3
File third_party/tcmalloc/PRESUBMIT.py (right):

http://codereview.chromium.org/465046/diff/1/3#newcode1
third_party/tcmalloc/PRESUBMIT.py:1: #!/usr/bin/python
Remove this line. This file is not executable.

http://codereview.chromium.org/465046/diff/1/3#newcode6
third_party/tcmalloc/PRESUBMIT.py:6: """Chromium presubmit script for src/views.
Smell copy paste.

[Timur Iskhodzhanov, 2009-12-04 17:36:12]

http://codereview.chromium.org/465046/diff/1/3
File third_party/tcmalloc/PRESUBMIT.py (right):

http://codereview.chromium.org/465046/diff/1/3#newcode1
third_party/tcmalloc/PRESUBMIT.py:1: #!/usr/bin/python
This was copied from src/views/PRESUBMIT.py
Actually, "ls -l" shows it is executable, but I guess it is only imported and
not run directly.

On 2009/12/04 02:10:13, Marc-Antoine Ruel wrote:
> Remove this line. This file is not executable.

http://codereview.chromium.org/465046/diff/1/3#newcode6
third_party/tcmalloc/PRESUBMIT.py:6: """Chromium presubmit script for src/views.
You're right.
Fixed that

On 2009/12/04 02:10:13, Marc-Antoine Ruel wrote:
> Smell copy paste.

[M-A Ruel, 2009-12-04 17:46:03]

svn:executable was probably added by your default svn config. It's not a big
deal.

lgtm

On Dec 4, 2009 12:36 PM, <timurrrr@chromium.org> wrote:

http://codereview.chromium.org/465046/diff/1/3 File
third_party/tcmalloc/PRESUBMIT.py (right): htt...
This was copied from src/views/PRESUBMIT.py
Actually, "ls -l" shows it is executable, but I guess it is only
imported and not run directly.

On 2009/12/04 02:10:13, Marc-Antoine Ruel wrote: > > Remove this line. This
file is not executable...
You're right.
Fixed that

On 2009/12/04 02:10:13, Marc-Antoine Ruel wrote: > > Smell copy paste.
http://codereview.chromiu...

[Nicolas Sylvain, 2009-12-04 17:49:59]

lgtm