Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/browser/ui/browser_navigator.h

Issue 4647007: Fix navigation bugs, patch the right file, nuke an old file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add fix for 62545 Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator.h
diff --git a/chrome/browser/ui/browser_navigator.h b/chrome/browser/ui/browser_navigator.h
index aee08db4f4a86bc345a0f58db4d9ab7d394874e5..08f9c03384fce35c646eca5cd468b2fccacac61f 100644
--- a/chrome/browser/ui/browser_navigator.h
+++ b/chrome/browser/ui/browser_navigator.h
@@ -80,10 +80,12 @@ struct NavigateParams {
// CURRENT_TAB " " " NEW_FOREGROUND_TAB
// OFF_THE_RECORD target browser profile is incog. NEW_FOREGROUND_TAB
//
- // If disposition is NEW_WINDOW or NEW_POPUP, |show_window| is set to true
- // automatically.
// If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_SELECTED is
// removed from |tabstrip_add_types| automatically.
+ // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or
+ // SINGLETON_TAB, then |show_window| is set to true and
+ // TabStripModel::ADD_SELECTED is automatically added to
+ // |tabstrip_add_types|.
WindowOpenDisposition disposition;
// The transition type of the navigation. Default is PageTransition::LINK

Powered by Google App Engine
This is Rietveld 408576698