crosutils: Add vnc view of tests and running multiple tests for VM tests

crosutils: Add vnc view of tests running multiple tests for VM tests

Change-Id: I87c41e60797848192cee1f0c165215fcec8f5bd2

BUG=8850
TEST=Ran a few tests including suite_Smoke

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0814569

[sosa, 2010-11-07 22:31:21]

Thanks for fixing the board logic in cros_start_vm for devs without default
boards.

http://codereview.chromium.org/4647001/diff/3001/4001
File bin/cros_run_vm_test (right):

http://codereview.chromium.org/4647001/diff/3001/4001#newcode39
bin/cros_run_vm_test:39: if [ -z "${FLAGS_test_case}" ] && [ -z "${FLAGS_ARGV}"
]; then
It's kind of strange to have this.  Is your primary purpose of this is to allow
multiple tests but not break existing use of this function?  Maybe just use
space-delimited option rather than use test_case + argv

http://codereview.chromium.org/4647001/diff/3001/4002
File bin/cros_start_vm (right):

http://codereview.chromium.org/4647001/diff/3001/4002#newcode13
bin/cros_start_vm:13: DEFINE_string board "" "Board for VM image (unnecessary if
path given)"
maybe use get_default_board before this

http://codereview.chromium.org/4647001/diff/3001/4002#newcode25
bin/cros_start_vm:25: [ -n "${FLAGS_board}" ] &&
BOARD_PARAM="--board=${FLAGS_board}"
prob just use the default logic and pass --board=${FLAGS_board} or -z die if no
board present.

[kmixter1, 2010-11-08 00:36:48]

PTAL

http://codereview.chromium.org/4647001/diff/3001/4001
File bin/cros_run_vm_test (right):

http://codereview.chromium.org/4647001/diff/3001/4001#newcode39
bin/cros_run_vm_test:39: if [ -z "${FLAGS_test_case}" ] && [ -z "${FLAGS_ARGV}"
]; then
On 2010/11/07 22:31:21, sosa wrote:
> It's kind of strange to have this.  Is your primary purpose of this is to
allow
> multiple tests but not break existing use of this function?  Maybe just use
> space-delimited option rather than use test_case + argv

Yes, I originally did remove the quotes around ${FLAGS_test_case} being passed
to run_remote_tests to allow  specifying multiple tests like --test_case="testa
testb".  However, I thought it would be clearer and easier to type if the
command just worked analogously to run_remote_tests, where tests are passed as
argv.  However, I didn't wnat to break existing users, hence this compromise. 
That was my intention.  If you want me to use --test_case=<space> and continue
to ignore ARGV like we did before, I can.

http://codereview.chromium.org/4647001/diff/3001/4002
File bin/cros_start_vm (right):

http://codereview.chromium.org/4647001/diff/3001/4002#newcode13
bin/cros_start_vm:13: DEFINE_string board "" "Board for VM image (unnecessary if
path given)"
On 2010/11/07 22:31:21, sosa wrote:
> maybe use get_default_board before this

Done.

http://codereview.chromium.org/4647001/diff/3001/4002#newcode25
bin/cros_start_vm:25: [ -n "${FLAGS_board}" ] &&
BOARD_PARAM="--board=${FLAGS_board}"
On 2010/11/07 22:31:21, sosa wrote:
> prob just use the default logic and pass --board=${FLAGS_board} or -z die if
no
> board present.

Done, now analogous to bin/cros_run_vm_test.

[sosa, 2010-11-08 20:05:17]

LGTM w/ addition of warning

http://codereview.chromium.org/4647001/diff/9001/10001
File bin/cros_run_vm_test (right):

http://codereview.chromium.org/4647001/diff/9001/10001#newcode44
bin/cros_run_vm_test:44: [ -n "${FLAGS_test_case}" ] && tests=(
"${FLAGS_test_case}" )
How about deprecate the flag and print a warning saying you shouldn't use and it
use ARGV instead until we've fixed the builders (a week or so)