Issue 4644002: Refactor: move all the policy-template related targets into one gypi file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4644002: Refactor: move all the policy-template related targets into one gypi file (Closed)

Created:
10 years, 1 month ago by gfeher

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refactor: move all the policy-template related targets into one gypi file BUG=none TEST=build completes on all platforms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65510

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Total comments: 2

Patch Set 4 : address comments #

Patch Set 5 : rebase for commit #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -165 lines)			Patch
A	chrome/app/policy/policy_templates.gypi	View	1 2 3	1 chunk	+180 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4	2 chunks	+1 line, -95 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View		1 chunk	+0 lines, -70 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gfeher

I think this makes things nicer and better understandable. Please take a look when you ...

10 years, 1 month ago (2010-11-08 17:20:01 UTC) #1

M-A Ruel

10 years, 1 month ago (2010-11-08 17:34:47 UTC) #2

lgtm with style nits

http://codereview.chromium.org/4644002/diff/8001/9001
File chrome/app/policy/policy_templates.gypi (right):

http://codereview.chromium.org/4644002/diff/8001/9001#newcode8
chrome/app/policy/policy_templates.gypi:8: { 'targets': [
The format is weird, even if it was in the previous code, use this style
instead:
['OS=="win" or OS=="mac" or OS=="linux"', {
'targets': [

That's similar to line 49, 68, etc.

http://codereview.chromium.org/4644002/diff/8001/9001#newcode18
chrome/app/policy/policy_templates.gypi:18: ]
],

Expand Messages | Collapse Messages