Move click-to-play to about:flags.

Move click-to-play to about:flags.

XIB changes: Add an outlet |pluginDefaultSettingMatrix_| to ContentSettingsDialogController, hooked up to the associated matrix, to remove the click-to-play radio button.

While I'm at it, clean up a bit: 
* Remove the old --disable-click-to-play flag that reverted to the M6 behavior for blocked plugins
* Make ContentExceptionsWindowController use ContentSettingComboModel for the action popup.
* Make HostContentSettingsMapTest use AutoReset to reset command line switches.

BUG=62091
TEST=unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65953

[Bernhard Bauer, 2010-11-11 21:12:17]

Please review.

[Mattias Nissler (ping if slow), 2010-11-12 11:49:46]

I did a quick scan and have a single nit suggestion. Didn't do a thorough review
though.

http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
File chrome/browser/host_content_settings_map.h (right):

http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
chrome/browser/host_content_settings_map.h:253: ContentSetting
ClickToPlayFixup(ContentSettingsType content_type,
Maybe add a comment explaining what it does?

[jochen (gone - plz use gerrit), 2010-11-12 13:38:04]

lgtm

please include a description of the xib changes

you might want to consider to move the cleanup work into a separate CL for
easier merging around

http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
File chrome/browser/host_content_settings_map_unittest.cc (right):

http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
chrome/browser/host_content_settings_map_unittest.cc:96: CommandLine* cmd =
CommandLine::ForCurrentProcess();
can you make the other unit tests use this pattern as well?

[Bernhard Bauer, 2010-11-12 15:08:07]

On 2010/11/12 11:49:46, Mattias Nissler wrote:
> I did a quick scan and have a single nit suggestion. Didn't do a thorough
review
> though.
> 
>
http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
> File chrome/browser/host_content_settings_map.h (right):
> 
>
http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
> chrome/browser/host_content_settings_map.h:253: ContentSetting
> ClickToPlayFixup(ContentSettingsType content_type,
> Maybe add a comment explaining what it does?

Done, and moved it to .cc file to reduce clutter.

On 2010/11/12 13:38:04, jochen wrote:
> lgtm
> 
> please include a description of the xib changes
> 
> you might want to consider to move the cleanup work into a separate CL for
> easier merging around

Meh. The point of making ContentExceptionsWindowController use
ContentSettingComboModel was because I was too lazy to change the settings array
there as well, so if I split it up, I'd have to merge both changes.

>
http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
> File chrome/browser/host_content_settings_map_unittest.cc (right):
> 
>
http://codereview.chromium.org/4643007/diff/16001/chrome/browser/host_content...
> chrome/browser/host_content_settings_map_unittest.cc:96: CommandLine* cmd =
> CommandLine::ForCurrentProcess();
> can you make the other unit tests use this pattern as well?

done.