Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 464084: Cache failed DNS resolutions for 1 second.... (Closed)

Created:
11 years ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.
Visibility:
Public.

Description

Cache failed DNS resolutions for 1 second. This is a very small time to live, since we want to be able to respond quickly when formerly unresolvable names become resolvable. Even such a small time is still useful, since cache misses for unresolvable names can be extremely costly (order of several seconds). For example, in our corp PAC script, the URL's host is resolved 3 times, so: Without caching, total runtime is (2.5 seconds) * 3 --> 7.5 seconds. Whereas with caching it would be: (2.5 seconds) * 1 --> 2.5 seconds This time to live will need to be tuned as part of bug 25472. BUG=11079 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34238

Patch Set 1 #

Patch Set 2 : Add a missing check #

Patch Set 3 : Merge changes (to include API change in another file) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -72 lines) Patch
M net/base/host_cache.h View 1 2 3 chunks +15 lines, -7 lines 0 comments Download
M net/base/host_cache.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M net/base/host_cache_unittest.cc View 1 2 7 chunks +75 lines, -13 lines 0 comments Download
M net/base/host_resolver_impl.h View 1 2 3 chunks +13 lines, -10 lines 0 comments Download
M net/base/host_resolver_impl.cc View 1 2 6 chunks +18 lines, -12 lines 0 comments Download
M net/base/host_resolver_impl_unittest.cc View 1 2 15 chunks +21 lines, -16 lines 0 comments Download
M net/base/mock_host_resolver.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M net/tools/hresolv/hresolv.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/url_request/url_request_view_net_internals_job.cc View 1 2 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
11 years ago (2009-12-09 04:17:19 UTC) #1
darin (slow to review)
11 years ago (2009-12-09 17:40:13 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698