Issue 464074: Enable Pepper support by default, including building the test plugin....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464074: Enable Pepper support by default, including building the test plugin.... (Closed)

Created:
11 years ago by sehr (please use chromium)

Modified:
9 years, 7 months ago

Reviewers:
brettw, jam

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable Pepper support by default, including building the test plugin. This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the --internal-pepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34161

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -58 lines)			Patch
M	build/all.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/common.gypi	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	2 chunks	+20 lines, -12 lines	0 comments	Download
M	webkit/glue/plugins/npapi_extension_thunk.cc	View	1	2 chunks	+0 lines, -17 lines	0 comments	Download
M	webkit/glue/plugins/plugin_host.cc	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
M	webkit/glue/webplugin.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webplugin_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/tools/pepper_test_plugin/README	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/event_handler.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages