Issue 464069: Fix for issue 545: don't reuse this VariableProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464069: Fix for issue 545: don't reuse this VariableProxy. (Closed)

Created:
11 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix for issue 545: don't reuse this VariableProxy.

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -5 lines)			Patch
M	src/compiler.cc	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/scopes.h	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/scopes.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
A	test/mjsunit/regress/regress-545.js	View	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years ago (2009-12-08 09:35:54 UTC) #2

LGTM.

It's a wart that 'this' is a Variable at all since it's a keyword in the syntax
and it's treated as an exception in the code more often than it's treated as a
normal variable.  We should just change that.

http://codereview.chromium.org/464069/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/464069/diff/1/2#newcode59
src/compiler.cc:59: ASSERT_EQ(Expression::kUninitialized, expr->context());
As we discussed, change this to

ASSERT(expr->context() == Expression::kUninitialzed ||
       expr->context() == context);

Expand Messages | Collapse Messages