Issue 464068: Fix the way the temporary directory is created.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464068: Fix the way the temporary directory is created. (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix the way the temporary directory is created. It is much cleaner and works for cases where the directory is not writeable. Also fix an unrelated unit test.

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	gcl.py	View		3 chunks	+8 lines, -13 lines	1 comment	Download
	M	tests/gcl_unittest.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

11 years ago (2009-12-08 02:45:33 UTC) #2

LGTM

http://codereview.chromium.org/464068/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/464068/diff/1/2#newcode718
gcl.py:718: # If the user specified a custom diff command in their svn config
file,
tabbing

Expand Messages | Collapse Messages