Issue 464044: Roll DEPS for Skia 450:451. Enable USE_NEW_BUILDER in Skia. Mark as failing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464044: Roll DEPS for Skia 450:451. Enable USE_NEW_BUILDER in Skia. Mark as failing... (Closed)

Created:
11 years ago by Stephen White

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Roll DEPS for Skia 450:451. Enable USE_NEW_BUILDER in Skia. Mark as failing the ~85 layout tests that now need rebaselining (due to slight pixel coverage change). Refactor SkUserConfig.h a tad. Rebaseline unit test VectorCanvasTest.ClippingIntersect. BUG=24646 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33863

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -25 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	skia/config/SkUserConfig.h	View		5 chunks	+10 lines, -21 lines	0 comments	Download
M	skia/ext/data/vectorcanvastest/clippingintersect/00_pc_intersect.png	View		Binary file		0 comments	Download
M	skia/ext/data/vectorcanvastest/clippingintersect/00_vc_intersect.png	View		Binary file		0 comments	Download
M	skia/skia.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1	4 chunks	+152 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Stephen White

On 2009/12/04 21:24:27, Dimitri Glazkov wrote: > LGTM. > > This is not funny. Would ...

11 years ago (2009-12-04 21:27:40 UTC) #3

A little bit.

Expand Messages | Collapse Messages