Issue 464002: Move for-in cache validity check to generated code.

Issue 464002: Move for-in cache validity check to generated code. (Closed)

Created:
11 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move for-in cache validity check to generated code. Committed: http://code.google.com/p/v8/source/detail?r=3407

Patch Set 1 #

Total comments: 18

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -9 lines)			Patch
M	src/arm/codegen-arm.cc	View	2 chunks	+59 lines, -5 lines	11 comments	Download
M	src/ia32/codegen-ia32.cc	View	2 chunks	+53 lines, -3 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+50 lines, -1 line	7 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM! http://codereview.chromium.org/464002/diff/1/4 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/464002/diff/1/4#newcode1779 src/arm/codegen-arm.cc:1779: frame_->EmitPush(r0); // push the object being iterated over ...

11 years ago (2009-12-03 08:49:32 UTC) #2

Mads Ager (chromium)

11 years ago (2009-12-03 10:15:31 UTC) #3

Thanks!

http://codereview.chromium.org/464002/diff/1/4
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/464002/diff/1/4#newcode1779
src/arm/codegen-arm.cc:1779: frame_->EmitPush(r0);  // push the object being
iterated over
On 2009/12/03 08:49:32, Erik Corry wrote:
> !punctuatioN

Done.

http://codereview.chromium.org/464002/diff/1/4#newcode1793
src/arm/codegen-arm.cc:1793: __ cmp(r2, Operand(Factory::empty_fixed_array()));
On 2009/12/03 08:49:32, Erik Corry wrote:
> This gets code-generated as a pc-relative load followed by a compare.  Please
> use LoadRoot instead to avoid the constant pool entry and reloc info.

Done.

http://codereview.chromium.org/464002/diff/1/4#newcode1800
src/arm/codegen-arm.cc:1800: __ cmp(r2,
Operand(Factory::empty_descriptor_array()));
On 2009/12/03 08:49:32, Erik Corry wrote:
> And here.

Done.

http://codereview.chromium.org/464002/diff/1/4#newcode1812
src/arm/codegen-arm.cc:1812: __ cmp(r2, Operand(Factory::empty_fixed_array()));
On 2009/12/03 08:49:32, Erik Corry wrote:
> And here (perhaps you can reuse the register so you don't have to reload the
> root).

Done.

http://codereview.chromium.org/464002/diff/1/4#newcode1817
src/arm/codegen-arm.cc:1817: __ cmp(r1, Operand(Factory::null_value()));
On 2009/12/03 08:49:32, Erik Corry wrote:
> And here.

Done.

http://codereview.chromium.org/464002/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/464002/diff/1/3#newcode1680
src/x64/codegen-x64.cc:1680: __ Cmp(rdx, Factory::empty_fixed_array());
On 2009/12/03 08:49:32, Erik Corry wrote:
> We have CompareRoot for this.  Same speed but more compact.

Done.

http://codereview.chromium.org/464002/diff/1/3#newcode1687
src/x64/codegen-x64.cc:1687: __ Cmp(rdx, Factory::empty_descriptor_array());
On 2009/12/03 08:49:32, Erik Corry wrote:
> And here

Done.

http://codereview.chromium.org/464002/diff/1/3#newcode1699
src/x64/codegen-x64.cc:1699: __ Cmp(rdx, Factory::empty_fixed_array());
On 2009/12/03 08:49:32, Erik Corry wrote:
> And here

Done.

http://codereview.chromium.org/464002/diff/1/3#newcode1704
src/x64/codegen-x64.cc:1704: __ Cmp(rcx, Factory::null_value());
And here.

Expand Messages | Collapse Messages