Issue 4640003: Fix pseudo-smi accessors lo/hi ordering for SharedFunctionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4640003: Fix pseudo-smi accessors lo/hi ordering for SharedFunctionInfo. (Closed)

Created:
10 years, 1 month ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix pseudo-smi accessors lo/hi ordering for SharedFunctionInfo on x64. Incorrect ordering lead to crashes during GC when end position was not even number. Add static assert to catch this kind of typos. Committed: http://code.google.com/p/v8/source/detail?r=5776

Patch Set 1 #

Total comments: 3

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/objects-inl.h	View		3 chunks	+5 lines, -3 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 1 month ago (2010-11-08 10:22:09 UTC) #2

LGTM

http://codereview.chromium.org/4640003/diff/1/2
File src/objects-inl.h (right):

http://codereview.chromium.org/4640003/diff/1/2#newcode2698
src/objects-inl.h:2698: kFormalParameterCountOffset)
Identation.

http://codereview.chromium.org/4640003/diff/1/2#newcode2701
src/objects-inl.h:2701: kExpectedNofPropertiesOffset)
Identation.

http://codereview.chromium.org/4640003/diff/1/2#newcode2706
src/objects-inl.h:2706: kStartPositionAndTypeOffset)
Indentation.

Expand Messages | Collapse Messages