Issue 4638005: Roll GTM r375:410

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4638005: Roll GTM r375:410 (Closed)

Created:
10 years, 1 month ago by davidben

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Roll GTM r375:410 Addresses an assert fired on the Mac whenever a new ConstrainedDialog is opened in the sheet end callback of another dialog, either from two consecutive sheets or having another sheet in the queue. This assert was fired from the client certificate selection dialog. (Also add myself to the AUTHORS file since I apparently never got around to doing that for contributions after my internship.) R=avi BUG=56948 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65625

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages