Issue 4637002: Adds the ability for classes other than native control to process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4637002: Adds the ability for classes other than native control to process (Closed)

Created:
10 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome

Visibility:
Public.

Description

Adds the ability for classes other than native control to process messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65612

Patch Set 1 #

Patch Set 2 : Tweaks #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -40 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_win.h	View		7 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View		5 chunks	+25 lines, -0 lines	0 comments	Download
M	views/controls/native_control_win.h	View		4 chunks	+8 lines, -10 lines	0 comments	Download
M	views/controls/native_control_win.cc	View	1	4 chunks	+8 lines, -7 lines	0 comments	Download
M	views/views.gyp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
A	views/widget/child_window_message_processor.h	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	views/widget/child_window_message_processor.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	views/widget/widget_win.cc	View		5 chunks	+21 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

My first attempt at landing this broke a couple of ui tests. I'm trying again. ...

10 years, 1 month ago (2010-11-10 01:08:01 UTC) #1

LGTM

Expand Messages | Collapse Messages