When an extension is uninstalled, close all desktop notifications from that e...

chrome/browser/notifications/balloon_collection_base.cc

Index: chrome/browser/notifications/balloon_collection_base.cc
===================================================================
--- chrome/browser/notifications/balloon_collection_base.cc	(revision 0)
+++ chrome/browser/notifications/balloon_collection_base.cc	(revision 0)
@@ -0,0 +1,75 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/balloon_collection_base.h"
+
+#include "base/stl_util-inl.h"
+#include "chrome/browser/notifications/notification.h"
+#include "googleurl/src/gurl.h"
+
+BalloonCollectionBase::BalloonCollectionBase() {
+}
+
+BalloonCollectionBase::~BalloonCollectionBase() {
+  STLDeleteElements(&balloons_);
+}
+
+void BalloonCollectionBase::Add(Balloon* balloon) {
+  balloons_.push_back(balloon);
+}
+
+void BalloonCollectionBase::Remove(Balloon* balloon) {
+  // Free after removing.
+  scoped_ptr<Balloon> to_delete(balloon);
+  Balloons::iterator iter;
+  for (iter = balloons_.begin(); iter != balloons_.end(); ++iter) {
+    if ((*iter) == balloon) {
+      balloons_.erase(iter);
+      return;
+    }
+  }
+}
+
+bool BalloonCollectionBase::CloseById(const std::string& id) {
+  // Use a local list of balloons to close to avoid breaking
+  // iterator changes on each close.
+  Balloons to_close;
+  Balloons::iterator iter;
+  for (iter = balloons_.begin(); iter != balloons_.end(); ++iter) {
+    if ((*iter)->notification().notification_id() == id)
+      to_close.push_back(*iter);
+  }
+  for (iter = to_close.begin(); iter != to_close.end(); ++iter)
+    (*iter)->CloseByScript();
+
+  return !to_close.empty();
+}
+
+bool BalloonCollectionBase::CloseAllBySourceOrigin(
+    const GURL& source_origin) {
+  // Use a local list of balloons to close to avoid breaking
+  // iterator changes on each close.
+  Balloons to_close;
+  Balloons::iterator iter;
+  for (iter = balloons_.begin(); iter != balloons_.end(); ++iter) {
+    if ((*iter)->notification().origin_url() == source_origin)
+      to_close.push_back(*iter);
+  }
+  for (iter = to_close.begin(); iter != to_close.end(); ++iter)
+    (*iter)->CloseByScript();
+
+  return !to_close.empty();
+}
+
+Balloon* BalloonCollectionBase::FindBalloon(
+    const Notification& notification) {
+  Balloons::iterator iter;
+  for (iter = balloons_.begin(); iter != balloons_.end(); ++iter) {
+    if ((*iter)->notification().notification_id() ==
+        notification.notification_id()) {
+      return *iter;

[Andrew T Wilson (Slow), 2010/11/11 01:07:44]

I'm not certain whether { should be omitted in this case (since the if statement
itself is multi-line). You seem to have a better grasp of the intricacies of the
style guide than I do, but figured I'd point this out in case it's an oversight.

[John Gregg, 2010/11/11 18:13:51]

Strangely the style guide doesn't actually spell out the rules, so I go with the
convention to use braces if the if condition spans multiple lines, cause it just
looks weird without them.

+    }
+  }
+  return NULL;
+}