 Chromium Code Reviews
 Chromium Code Reviews Issue 4635007:
  When an extension is uninstalled, close all desktop notifications from that e...  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src/
    
  
    Issue 4635007:
  When an extension is uninstalled, close all desktop notifications from that e...  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src/| Index: chrome/browser/notifications/balloon_collection.h | 
| =================================================================== | 
| --- chrome/browser/notifications/balloon_collection.h (revision 65581) | 
| +++ chrome/browser/notifications/balloon_collection.h (working copy) | 
| @@ -9,11 +9,13 @@ | 
| #pragma once | 
| #include <deque> | 
| +#include <string> | 
| #include "base/callback.h" | 
| #include "base/scoped_ptr.h" | 
| class Balloon; | 
| +class GURL; | 
| class Notification; | 
| class Profile; | 
| @@ -44,10 +46,12 @@ | 
| virtual void Add(const Notification& notification, | 
| Profile* profile) = 0; | 
| - // Removes a balloon from the collection if present. Returns | 
| - // true if anything was removed. | 
| - virtual bool Remove(const Notification& notification) = 0; | 
| + // Removes any balloons that have this notification id. | 
| 
Andrew T Wilson (Slow)
2010/11/11 01:07:44
Should we document what the return values of Remov
 
John Gregg
2010/11/11 18:13:51
Done.
 | 
| + virtual bool RemoveById(const std::string& id) = 0; | 
| + // Removes any balloons that have this source origin. | 
| + virtual bool RemoveBySourceOrigin(const GURL& source_origin) = 0; | 
| + | 
| // Is there room to add another notification? | 
| virtual bool HasSpace() const = 0; |