chrome/browser/automation/testing_automation_provider.cc - Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: lint fixes Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/notifications/balloon_collection_impl.h » ('j') | chrome/browser/chromeos/notifications/balloon_collection_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/testing_automation_provider.cc

===================================================================

--- chrome/browser/automation/testing_automation_provider.cc (revision 65581)

+++ chrome/browser/automation/testing_automation_provider.cc (working copy)

@@ -4259,7 +4259,7 @@

// This will delete itself when finished.

new OnNotificationBalloonCountObserver(

this, reply_message, collection, balloon_count - 1);

- manager->Cancel(balloons[index]->notification());

+ manager->CancelById(balloons[index]->notification().notification_id());

}

// Refer to WaitForNotificationCount() in chrome/test/pyautolib/pyauto.py for